Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update South Korea holidays: 2025 temporary public holidays #2218

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Update South Korea holidays: 2025 temporary public holidays #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89ebe46
Add South Korea's temporary public holidays
YiGeon Jan 8, 2025
86c8fb0
Update 2025 Temporary Public Holiday to KR_COMMON.json
YiGeon Jan 8, 2025
4460dd2
Update 2025 Temporary Public Holiday to test_south_korea.py
YiGeon Jan 8, 2025
4a35f01
Correcting incorrectly modified parts
YiGeon Jan 8, 2025
66ed363
Remove unnecessary brackets
YiGeon Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions holidays/countries/south_korea.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,8 @@ class SouthKoreaStaticHolidays:
2023: (OCT, 2, temporary_public_holiday),
# 76th Anniversary of the Armed Forces of Korea.
2024: (OCT, 1, armed_forces_day),
# Added to create a 6-day long holiday period.
2025: (JAN, 27, temporary_public_holiday),
arkid15r marked this conversation as resolved.
Show resolved Hide resolved
}
# Pre-2014 Alternate Holidays
# https://namu.wiki/w/대체%20휴일%20제도#s-4.2.1
Expand Down
1 change: 1 addition & 0 deletions snapshots/countries/KR_COMMON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,6 +1293,7 @@
"2024-10-09": "Hangul Day",
"2024-12-25": "Christmas Day",
"2025-01-01": "New Year's Day",
"2025-01-27": "Temporary Public Holiday",
"2025-01-28": "The day preceding Korean New Year",
"2025-01-29": "Korean New Year",
"2025-01-30": "The second day of Korean New Year",
Expand Down
1 change: 1 addition & 0 deletions tests/countries/test_south_korea.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def test_special_holidays(self):
"2020-08-17",
"2023-10-02",
"2024-10-01",
"2025-01-27",
)
# Pre-2014 Observance sans "1960-12-26"
self.assertNoNonObservedHoliday(
Expand Down
Loading