Add Ellipal metadata #1190
Merged
Add Ellipal metadata #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
reviewed
Oct 26, 2021
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
I get that we have the pools metadata in public due to historical reasons and it's tricky to switch because we'd have to update the pool registrations, but I'd consider at least moving in the codebase the metadata to public/pools_metadata subfolder so it's reasonably organized at least in the code, and serve them directly from our express backend, leaving there a clarifying comment why we are overriding the path when serving
as discussing offline, probably worth a follow-up issue so I'm creating it: #1191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.