Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ellipal metadata #1190

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add Ellipal metadata #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/public/ellipal-extended-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"info": {
"social": {
"twitter_handle": "ellipalwallet",
"telegram_handle": "",
"facebook_handle": "ellipalclub",
"youtube_handle": "",
"twitch_handle": "",
"discord_handle": "",
"github_handle": ""
}
},
"my-pool-ids": {
"0": "879ad8338e795acb7b2bd2cf5532ed4e3603962439c91cb0bd5ae7af"
},
"when-satured-then-recommend": {
"0": "879ad8338e795acb7b2bd2cf5532ed4e3603962439c91cb0bd5ae7af"
}
}
7 changes: 7 additions & 0 deletions app/public/ellipal-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@refi93 refi93 Oct 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that we have the pools metadata in public due to historical reasons and it's tricky to switch because we'd have to update the pool registrations, but I'd consider at least moving in the codebase the metadata to public/pools_metadata subfolder so it's reasonably organized at least in the code, and serve them directly from our express backend, leaving there a clarifying comment why we are overriding the path when serving

as discussing offline, probably worth a follow-up issue so I'm creating it: #1191

"name": "Ellipal wallet",
"description": "ELLIPAL Limited is a blockchain technology company focused on cryptocurrency safety and blockchain service facilities. ELLIPAL produces the most secure hardware wallets to Secure Storage, Secure Stake.",
"ticker": "ELLIP",
"homepage": "https://www.ellipal.com/pages/ellipal-staking",
"extended": "https://adalite.io/ellipal-extended-metadata.json"
}