Fixes output constraints for LOADFP instruction #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tess-eract
commented
May 7, 2024
| @@ -119,7 +119,7 @@ impl CpuChip { | |||
| ) | |||
| .assert_one(local.read_1_used()); | |||
| builder | |||
| .when(is_jal + is_left_imm_op) | |||
| .when(is_jal + is_left_imm_op + is_loadfp + is_imm32) | |||
There was a problem hiding this comment.
Here and below we add some missing cases to the memory channel constraints, asserting that the read channels are unused for IMM32 and LOADFP and that the write channel is unused for BEQ and BNE.
Syfextok
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #132.
Currently, the STARK constraints in the
CPUChipfor theLOADFPinstruction check that thewrite_valueis equal tofp, while the implementation of theLOADFPinstruction instead writesfp + b, wherebis the second operand.This PR changes the STARK constraints to set the output to
fp + b, and adds some tests tobasic/tests/test_prover.rsto check this behavior.