Java: Add WATCH and UNWATCH command
#1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
reviewed
Jun 6, 2024
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
|
Our review checklist includes the following, are they applicable for UNWATCH or no?
|
yipin-chen
approved these changes
Jun 8, 2024
|
Add |
acarbonetto
reviewed
Jun 11, 2024
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
GumpacG
force-pushed
the
java/dev_guiang_watch
branch
2 times, most recently
from
1c1e123 to
57f03b6
Compare
| @@ -575,4 +578,10 @@ public CompletableFuture<ClusterValue<Object>> fcall( | |||
| ? ClusterValue.ofSingleValue(handleObjectOrNullResponse(response)) | |||
| : ClusterValue.ofMultiValue(handleMapResponse(response))); | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<String> unwatch(@NonNull Route route) { | |||
There was a problem hiding this comment.
TBD do we need this? Does user need this?
java/client/src/main/java/glide/api/commands/TransactionsBaseClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Outdated
Show resolved
Hide resolved
| @@ -781,7 +781,8 @@ public static Stream<Arguments> callCrossSlotCommandsWhichShouldPass() { | |||
| Arguments.of("del", clusterClient.del(new String[] {"abc", "zxy", "lkn"})), | |||
| Arguments.of("mget", clusterClient.mget(new String[] {"abc", "zxy", "lkn"})), | |||
| Arguments.of("mset", clusterClient.mset(Map.of("abc", "1", "zxy", "2", "lkn", "3"))), | |||
| Arguments.of("touch", clusterClient.touch(new String[] {"abc", "zxy", "lkn"}))); | |||
| Arguments.of("touch", clusterClient.touch(new String[] {"abc", "zxy", "lkn"})), | |||
| Arguments.of("watch", clusterClient.watch(new String[] {"ghi", "zxy", "lkn"}))); | |||
GumpacG
force-pushed
the
java/dev_guiang_watch
branch
from
4691a96 to
e1611ae
Compare
Yury-Fridlyand
approved these changes
Jun 13, 2024
GumpacG
force-pushed
the
java/dev_guiang_watch
branch
2 times, most recently
from
b1d3565 to
d2a873b
Compare
acarbonetto
approved these changes
Jun 16, 2024
aaron-congo
reviewed
Jun 17, 2024
java/client/src/main/java/glide/api/commands/TransactionsBaseCommands.java
Show resolved
Hide resolved
GumpacG
force-pushed
the
java/dev_guiang_watch
branch
from
2cb8365 to
f605ee6
Compare
acarbonetto
approved these changes
Jun 17, 2024
This was referenced Jun 17, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
* Java: Add `WATCH` and `UNWATCH` command * Addressed PR comments * Added unwatch with route and improved tests * Fixed test based on submodule changes * Addressed PR comments * Added example for watch returning null * Added crossSlot test * Addressed comments * Commented out a test due to a bug * Address PR comments
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add `WATCH` and `UNWATCH` command * Addressed PR comments * Added unwatch with route and improved tests * Fixed test based on submodule changes * Addressed PR comments * Added example for watch returning null * Added crossSlot test * Addressed comments * Commented out a test due to a bug * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implements
WATCHandUNWATCHcommands in the java client.Note: This is blocked and depends on amazon-contributing/redis-rs#157
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.