Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add the XREADGROUP command #1613

Merged

Conversation

acarbonetto
Copy link
Contributor

Issue #, if available:

Description of changes:

Adds the XREADGROUP command to Java

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Add XGROUP CreateConsumer, DelConsumer

Signed-off-by: Andrew Carbonetto <[email protected]>

* Add XREADGROUP command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Udpate IT tests

Signed-off-by: Andrew Carbonetto <[email protected]>

* Fix IT tests

Signed-off-by: Andrew Carbonetto <[email protected]>

* SPOTLESS & merge conflict fix

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update for review comments

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto requested a review from a team as a code owner June 19, 2024 22:34
Signed-off-by: Andrew Carbonetto <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Jun 20, 2024
@acarbonetto acarbonetto changed the title Java: Add the XREADGROUP command (#376) Java: Add the XREADGROUP command Jun 20, 2024
@acarbonetto acarbonetto self-assigned this Jun 20, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit 75d784e into valkey-io:main Jun 20, 2024
46 checks passed
@acarbonetto acarbonetto deleted the java/integ_acarbo_add_xreadgroup branch June 20, 2024 03:23
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: Add the `XREADGROUP` command (#376)

* Add XGROUP CreateConsumer, DelConsumer

Signed-off-by: Andrew Carbonetto <[email protected]>

* Add XREADGROUP command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Udpate IT tests

Signed-off-by: Andrew Carbonetto <[email protected]>

* Fix IT tests

Signed-off-by: Andrew Carbonetto <[email protected]>

* SPOTLESS & merge conflict fix

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update for review comments

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Remove old test from IT suite

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update xreadgroup docs

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants