-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add the XREADGROUP
command
#1613
Merged
acarbonetto
merged 3 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xreadgroup
Jun 20, 2024
Merged
Java: Add the XREADGROUP
command
#1613
acarbonetto
merged 3 commits into
valkey-io:main
from
Bit-Quill:java/integ_acarbo_add_xreadgroup
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamReadGroupOptions.java
Show resolved
Hide resolved
acarbonetto
changed the title
Java: Add the
Java: Add the Jun 20, 2024
XREADGROUP
command (#376)XREADGROUP
command
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Jun 20, 2024
Elen-Ghulam
approved these changes
Jun 20, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add the `XREADGROUP` command (#376) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Remove old test from IT suite Signed-off-by: Andrew Carbonetto <[email protected]> * Update xreadgroup docs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds the XREADGROUP command to Java
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.