Changed the API to support binary transaction #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jduo
suggested changes
Jun 30, 2024
java/integTest/src/test/java/glide/cluster/ClusterTransactionTests.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Jun 30, 2024
In addition, the following commands are modified to support it: customCommand, echo, ping, del, get, getdel, getex, set, append, mget, mset, msetnx, incr, incrBy, incrByFloat, decr, decrBy, strlen, setrange , getrange, hget, hset, hsetnx, hdel, hlen, hvals, hmget, spopCount
Restored large value tests
eifrah-aws
force-pushed
the
java-transaction-binary-base-change
branch
from
7fba7ef to
3e906d4
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Changed the API to support binary transaction In addition, the following commands are modified to support it: customCommand, echo, ping, del, get, getdel, getex, set, append, mget, mset, msetnx, incr, incrBy, incrByFloat, decr, decrBy, strlen, setrange , getrange, hget, hset, hsetnx, hdel, hlen, hvals, hmget, spopCount * Temporarily disable large-values tests * ArgsBuilder now collects all arguments and returns `GlideString[]` Restored large value tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the binary API for Transactions + changes numerous commands (TXN commands) to accept either
StringorGlideStringBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.