Fix parent dataset resolution in facet lift planner stage #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a facet group mark like this:
The facet lift optimization introduces a new dataset (named
data_0_facet_facet0
) and intends to insert this new dataset alongside the facet mark's input dataset (data_0
in this case). Notice that in this case, the facet group mark has a nested dataset also nameddata_0
. The error we were making is that we would mistakenly resolvedata_0
to be the nested dataset and place the newdata_0_facet_facet0
nested inside the facet group mark, where it is not visible from the facet definition.The fix is to only resolve the source dataset in the scope above the facet definition.
A previously failing test is added