Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent dataset resolution in facet lift planner stage #439

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

jonmmease
Copy link
Collaborator

Consider a facet group mark like this:

    {
      "name": "cell",
      "type": "group",
      "style": "cell",
      "from": {
        "facet": {
          "name": "facet",
          "data": "data_0",
          "groupby": [
            "MPAA Rating"
          ]
        }
      },
      "sort": {
        "field": [
          "datum[\"MPAA Rating\"]"
        ],
        "order": [
          "ascending"
        ]
      },
      "data": [
        {
          "source": "facet",
          "name": "data_0",
...

The facet lift optimization introduces a new dataset (named data_0_facet_facet0) and intends to insert this new dataset alongside the facet mark's input dataset (data_0 in this case). Notice that in this case, the facet group mark has a nested dataset also named data_0. The error we were making is that we would mistakenly resolve data_0 to be the nested dataset and place the new data_0_facet_facet0 nested inside the facet group mark, where it is not visible from the facet definition.

The fix is to only resolve the source dataset in the scope above the facet definition.

A previously failing test is added

@jonmmease jonmmease merged commit f3424d6 into main Dec 21, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant