Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent dataset resolution in facet lift planner stage #439

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix parent dataset resolution in facet lift planner stage #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vegafusion-core/src/planning/lift_facet_aggregations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ impl MutChartVisitor for ExtractFacetAggregationsVisitor {
// Save new dataset at the same scope as the original input dataset
let Ok(resolved) = self
.task_scope
.resolve_scope(&Variable::new_data(&facet.data), scope)
.resolve_scope(&Variable::new_data(&facet.data), &scope[..scope.len() - 1])
else {
return Ok(());
};
Expand Down
30 changes: 30 additions & 0 deletions vegafusion-runtime/tests/specs/custom/facet_with_selections.comm_plan.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"server_to_client": [
{
"name": "column_domain",
"namespace": "data",
"scope": []
},
{
"name": "data_0_color_domain_MPAA Rating",
"namespace": "data",
"scope": []
},
{
"name": "data_0_facet_facet0",
"namespace": "data",
"scope": []
},
{
"name": "data_3",
"namespace": "data",
"scope": []
},
{
"name": "data_3_x_domain_Creative Type",
"namespace": "data",
"scope": []
}
],
"client_to_server": []
}
Loading
Loading