feat: remove invariant check and apply cap to rebate factor #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiajia-Cui
reviewed
Aug 15, 2024
Jiajia-Cui
reviewed
Aug 15, 2024
Jiajia-Cui
reviewed
Aug 15, 2024
cdummett
force-pushed
the
feat/remove-invariant
branch
from
701507e to
c8674f5
Compare
Jiajia-Cui
reviewed
Aug 15, 2024
Jiajia-Cui
reviewed
Aug 15, 2024
Jiajia-Cui
reviewed
Aug 15, 2024
Jiajia-Cui
previously approved these changes
Aug 15, 2024
cdummett
force-pushed
the
feat/remove-invariant
branch
from
4233f94 to
ef1e2fd
Compare
Jiajia-Cui
previously approved these changes
Aug 19, 2024
Jiajia-Cui
previously approved these changes
Aug 19, 2024
Jiajia-Cui
previously approved these changes
Aug 19, 2024
Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: Jiajia-Cui <[email protected]>
This reverts commit fae5a0e.
cdummett
force-pushed
the
feat/remove-invariant
branch
from
2e452bf to
f6020af
Compare
davidsiska-vega
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... based off slack thread and core PR vegaprotocol/vega#11578.
PR removes invariance check and instead caps the rebate factor to a maximum which is the sum of the treasury and buy back fee factors.
Maximum should be recalculated and applied on governance proposals updating factors.