Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Implement New Overlay Layout with Bottom Stacks #74466

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 2, 2025

This PR added the bottom stacks.

Light/Dark Mode Testing Plan

Toggle the device system theme. We might want to consider handling it as a state.

CleanShot 2025-01-02 at 22.07.45.png

Light

CleanShot.2025-01-02.at.22.47.21.mp4

Dark

CleanShot.2025-01-02.at.22.46.56.mp4

Closes NDX-570

@ijjk
Copy link
Member

ijjk commented Jan 2, 2025

Tests Passed

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 2, 2025 13:09
@ijjk
Copy link
Member

ijjk commented Jan 2, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
buildDuration 17.8s 15.1s N/A
buildDurationCached 14.4s 12.2s N/A
nodeModulesSize 416 MB 417 MB ⚠️ +80.6 kB
nextStartRea..uration (ms) 397ms 393ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
index.html gzip 524 B 522 B N/A
link.html gzip 538 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
middleware-b..fest.js gzip 669 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 360 kB 361 kB ⚠️ +817 B
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 349 kB 350 kB ⚠️ +839 B
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB ⚠️ +1.66 kB
build cache
vercel/next.js canary vercel/next.js 01-02-_devoverlay_add_bottom_stacks Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.4 kB 74.3 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 62067ba

@devjiwonchoi devjiwonchoi changed the title [DevOverlay] Add bottom stacks [DevOverlay] Implement New Overlay Layout with Bottom Stacks Jan 2, 2025
@devjiwonchoi devjiwonchoi requested review from ijjk and gaojude January 2, 2025 17:12
@devjiwonchoi devjiwonchoi force-pushed the 01-02-_devoverlay_add_color_palette_script branch from a2ec4de to 063d43d Compare January 3, 2025 02:20
@devjiwonchoi devjiwonchoi force-pushed the 01-02-_devoverlay_add_bottom_stacks branch from 5383999 to 1323336 Compare January 3, 2025 02:20
Copy link
Member Author

devjiwonchoi commented Jan 3, 2025

Merge activity

  • Jan 3, 7:07 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 3, 7:39 AM EST: Graphite couldn't merge this pull request because a downstack PR [DevOverlay] Add color palette script #74465 failed to merge.
  • Jan 3, 8:17 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 3, 8:20 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 3, 8:45 AM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'test ppr dev (1/6) / build').

@devjiwonchoi devjiwonchoi changed the base branch from 01-02-_devoverlay_add_color_palette_script to graphite-base/74466 January 3, 2025 12:08
@devjiwonchoi devjiwonchoi force-pushed the 01-02-_devoverlay_add_bottom_stacks branch from 19809d3 to 26b6f51 Compare January 3, 2025 12:36
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74466 to canary January 3, 2025 13:18
@devjiwonchoi devjiwonchoi force-pushed the 01-02-_devoverlay_add_bottom_stacks branch from 26b6f51 to 62067ba Compare January 3, 2025 13:19
@devjiwonchoi devjiwonchoi merged commit e5f60d6 into canary Jan 3, 2025
140 of 141 checks passed
@devjiwonchoi devjiwonchoi deleted the 01-02-_devoverlay_add_bottom_stacks branch January 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants