Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Remove temporary header children #74490

Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 3, 2025

Why?

The header children were temporary because they will affect the test utils in the future, we need to change these query selectors from data-nextjs-dialog-header to data-nextjs-dialog-body:

.find((p) => p.shadowRoot.querySelector('[data-nextjs-dialog-header]'))
const root = portal.shadowRoot
const text = root.querySelector(
'#nextjs__container_errors__link'

This is not a severe blocker, and we may follow up on this during the QA period when we enable CI tests for the new UI.
We may even have to unify the target attributes for testing before the change.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 3, 2025
@ijjk
Copy link
Member

ijjk commented Jan 3, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
buildDuration 19s 16.9s N/A
buildDurationCached 15.9s 13.4s N/A
nodeModulesSize 417 MB 417 MB N/A
nextStartRea..uration (ms) 479ms 489ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
1187-HASH.js gzip 52.6 kB 52.6 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
index.html gzip 524 B 522 B N/A
link.html gzip 538 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
middleware-b..fest.js gzip 667 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 362 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 351 kB 351 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.73 MB 1.73 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-03-_devoverlay_remove_temporary_header_children Change
0.pack gzip 2.08 MB 2.09 MB ⚠️ +5.03 kB
index.pack gzip 73.7 kB 74.8 kB ⚠️ +1.16 kB
Overall change 2.15 MB 2.16 MB ⚠️ +6.19 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 5110212

@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_remove_temporary_header_children branch from 25ad5de to 152f52e Compare January 3, 2025 13:52
@devjiwonchoi devjiwonchoi changed the base branch from canary to 01-03-_devoverlay_add_error_overlay_footer_and_feedback January 3, 2025 13:52
@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 3, 2025 13:56
@ijjk
Copy link
Member

ijjk commented Jan 3, 2025

Tests Passed

@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_add_error_overlay_footer_and_feedback branch 2 times, most recently from a6963e7 to 1cb7b79 Compare January 3, 2025 15:56
@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_remove_temporary_header_children branch from 152f52e to 8d25948 Compare January 3, 2025 15:56
@devjiwonchoi devjiwonchoi requested review from ijjk and gaojude January 3, 2025 16:02
@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_add_error_overlay_footer_and_feedback branch from 1cb7b79 to 63c76c5 Compare January 3, 2025 16:25
@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_remove_temporary_header_children branch from 8d25948 to e09c189 Compare January 3, 2025 16:25
Copy link
Member Author

devjiwonchoi commented Jan 3, 2025

Merge activity

  • Jan 3, 1:08 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 3, 1:11 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 3, 1:39 PM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'test prod (5/7) / build', 'test ppr dev (2/6) / build').
  • Jan 3, 2:12 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi changed the base branch from 01-03-_devoverlay_add_error_overlay_footer_and_feedback to graphite-base/74490 January 3, 2025 18:09
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74490 to canary January 3, 2025 18:09
@devjiwonchoi devjiwonchoi force-pushed the 01-03-_devoverlay_remove_temporary_header_children branch from e09c189 to 5110212 Compare January 3, 2025 18:10
@devjiwonchoi devjiwonchoi merged commit a07559f into canary Jan 3, 2025
131 checks passed
@devjiwonchoi devjiwonchoi deleted the 01-03-_devoverlay_remove_temporary_header_children branch January 3, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants