Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow 256 pods per node. #119

Closed
wants to merge 5 commits into from
Closed

chore: allow 256 pods per node. #119

wants to merge 5 commits into from

Conversation

ricolin
Copy link
Member

@ricolin ricolin commented May 21, 2024

Currently we have more then 100 pods per node.
And this make it impossible to add new pods for any service. This patch propse to increase maxPods for kubelet to 256 instead of default 110.

relate to: vexxhost/atmosphere#1192

Currently we have more then 100 pods per node.
And this make it impossible to add new pods for any service.
This patch propse to increase maxPods for kubelet to 256 instead of
default 110.
@ricolin
Copy link
Member Author

ricolin commented May 21, 2024

seems rockylinux8 uses python3.6 and hit https://stackoverflow.com/questions/52889746/cant-import-annotations-from-future

@ricolin ricolin force-pushed the allow-256-max-pods branch from 9b1852d to 8fc0eff Compare May 21, 2024 07:26
Currently requests >= 2.31.0 seems broken molecule docker connect
with error: `Unable to contact the Docker daemon`
@ricolin ricolin force-pushed the allow-256-max-pods branch 3 times, most recently from d63112b to 30c5866 Compare May 21, 2024 08:21
ricolin added 2 commits May 21, 2024 23:45
`future feature annotations is not defined` will occur when calling
ansible.legacy.setup.
@ricolin
Copy link
Member Author

ricolin commented May 22, 2024

recheck

@ricolin ricolin requested review from okozachenko1203 and mnaser May 22, 2024 05:31
@@ -1,8 +1,10 @@
ansible-core
ansible-core < 2.17.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricolin is it because 2.17 breaks something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there is a syntax error in 2.17 when ansible try to talk with rockylinux8 environment
I leave the detail here: #119 (comment)

So IMO, we either constrain this version or drop rockylinux8 from CI

Copy link
Contributor

@fitbeard fitbeard May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RHEL world this can/should be fixed by installing python3x using dnf and switched from default system Python using 'update-alternatives'. Distro's Python version will stay 3.6 til EOL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the concern I have is we either support default rockylinux8 or ask to switch the python in rockylinux8 to fit this collection needs

I think we can use update-alternatives in real cases but not that handy in CI. Just make a patch to reinstall python to 3.9 so we don't need to touch ansible-core requirement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately can not change python version from molecule prepare stage as it failed on Gethering fact for prepare

PLAY [Prepare] *****************************************************************
  
  TASK [Gathering Facts] *********************************************************
  fatal: [instance]: FAILED! => {"ansible_facts": {}, "changed": false, "failed_modules": {"ansible.legacy.setup": {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "exception": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line [99](https://github.com/vexxhost/ansible-collection-kubernetes/actions/runs/9202557352/job/25312618142?pr=119#step:6:105), in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_8qv9jvhz/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "failed": true, "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line 99, in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_8qv9jvhz/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}}, "msg": "The following modules failed to execute: ansible.legacy.setup\n"}

let me revert 7677c98 for now

@ricolin
Copy link
Member Author

ricolin commented May 22, 2024

The ansible-core version limit is targeting following error on with ansible-> rockylinux8 environment.
Appears when ansible-core (> 2.17.0) connect to rockylinux8 environment, there is a bug in ansible.legacy.setup for this flow and shows below error:

 fatal: [instance]: FAILED! => {"ansible_facts": {}, "changed": false, "failed_modules": {"ansible.legacy.setup": {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "exception": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line 99, in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_ybttz03h/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "failed": true, "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line 99, in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_ybttz03h/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}}, "msg": "The following modules failed to execute: ansible.legacy.setup\n"}

@ricolin ricolin force-pushed the allow-256-max-pods branch from 7677c98 to 981c0ab Compare May 23, 2024 08:18
@ricolin ricolin closed this Jan 15, 2025
@ricolin ricolin deleted the allow-256-max-pods branch January 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants