Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow 256 pods per node. #119

Closed
wants to merge 5 commits into from
Closed

chore: allow 256 pods per node. #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac80f04
chore: allow 256 pods per node.
ricolin May 21, 2024
30c5866
fix molecule requirements
ricolin May 21, 2024
3936f31
rockylinux8 doesn't work with ansible-core >= 2.17.0
ricolin May 21, 2024
981c0ab
Retry on k8s task
ricolin May 22, 2024
0fedf90
Merge branch 'main' into allow-256-max-pods
ricolin Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
ansible-core
ansible-core < 2.17.0
docker-image-py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricolin is it because 2.17 breaks something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah there is a syntax error in 2.17 when ansible try to talk with rockylinux8 environment
I leave the detail here: #119 (comment)

So IMO, we either constrain this version or drop rockylinux8 from CI

Copy link
Contributor

@fitbeard fitbeard May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RHEL world this can/should be fixed by installing python3x using dnf and switched from default system Python using 'update-alternatives'. Distro's Python version will stay 3.6 til EOL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the concern I have is we either support default rockylinux8 or ask to switch the python in rockylinux8 to fit this collection needs

I think we can use update-alternatives in real cases but not that handy in CI. Just make a patch to reinstall python to 3.9 so we don't need to touch ansible-core requirement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately can not change python version from molecule prepare stage as it failed on Gethering fact for prepare

PLAY [Prepare] *****************************************************************
  
  TASK [Gathering Facts] *********************************************************
  fatal: [instance]: FAILED! => {"ansible_facts": {}, "changed": false, "failed_modules": {"ansible.legacy.setup": {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "exception": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line [99](https://github.com/vexxhost/ansible-collection-kubernetes/actions/runs/9202557352/job/25312618142?pr=119#step:6:105), in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_8qv9jvhz/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "failed": true, "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 107, in <module>\n  File \"<stdin>\", line 99, in _ansiballz_main\n  File \"<stdin>\", line 44, in invoke_module\n  File \"<frozen importlib._bootstrap>\", line 971, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 951, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 894, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1157, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1131, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1112, in _legacy_get_spec\n  File \"<frozen importlib._bootstrap>\", line 441, in spec_from_loader\n  File \"<frozen importlib._bootstrap_external>\", line 544, in spec_from_file_location\n  File \"/tmp/ansible_ansible.legacy.setup_payload_8qv9jvhz/ansible_ansible.legacy.setup_payload.zip/ansible/module_utils/basic.py\", line 5\nSyntaxError: future feature annotations is not defined\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}}, "msg": "The following modules failed to execute: ansible.legacy.setup\n"}

let me revert 7677c98 for now

jmespath
molecule
molecule-plugins[docker]
pytest < 8.0.0
pytest-forked
pytest-xdist
PyYAML > 6.0.0
requests < 2.31.0
2 changes: 2 additions & 0 deletions roles/kubernetes/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@
template:
spec:
nodeSelector: "{{ kubernetes_coredns_node_selector }}"
retries: 10
delay: 1
1 change: 1 addition & 0 deletions roles/kubernetes/templates/kubeadm.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ scheduler:
---
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
maxPods: 256
---
apiVersion: kubeproxy.config.k8s.io/v1alpha1
kind: KubeProxyConfiguration
Expand Down
Loading