-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHOW VSCHEMA KEYSPACES
query
#14505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
labels
Nov 10, 2023
GuptaManan100
requested review from
harshit-gangal,
systay,
frouioui and
arthurschreiber
as code owners
November 10, 2023 08:08
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 10, 2023
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
fk-mode-keyspace
branch
from
November 10, 2023 08:34
0948856
to
861bc4c
Compare
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 10, 2023
harshit-gangal
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix upgrade downgrade test
2023-11-10T09:17:03.2520559Z === RUN TestInitAndUpdate
2023-11-10T09:17:03.3682409Z st_sharded_test.go:195:
2023-11-10T09:17:03.3683627Z Error Trace: /home/runner/work/vitess/vitess/go/test/endtoend/utils/utils.go:153
2023-11-10T09:17:03.3686117Z /home/runner/work/vitess/vitess/go/test/endtoend/utils/utils.go:48
2023-11-10T09:17:03.3689435Z /home/runner/work/vitess/vitess/go/test/endtoend/vtgate/schematracker/sharded/st_sharded_test.go:195
2023-11-10T09:17:03.3690912Z Error: Received unexpected error:
2023-11-10T09:17:03.3692982Z syntax error at position 23 near 'KEYSPACES' (errno 1105) (sqlstate HY000) during query: SHOW VSCHEMA KEYSPACES
2023-11-10T09:17:03.3694454Z Test: TestInitAndUpdate
2023-11-10T09:17:03.3695102Z Messages: for query: SHOW VSCHEMA KEYSPACES
2023-11-10T09:17:03.3695708Z --- FAIL: TestInitAndUpdate (0.12s)
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
harshit-gangal
approved these changes
Nov 13, 2023
systay
added
NeedsWebsiteDocsUpdate
What it says
and removed
NeedsWebsiteDocsUpdate
What it says
labels
Nov 13, 2023
systay
approved these changes
Nov 13, 2023
This was referenced Nov 24, 2023
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Vitess specific query syntax to vtgates,
SHOW VSCHEMA KEYSPACES
. This query is intended to print out the information of all the keyspaces that Vitess has. Specifically, this query prints out the keyspace name, whether it is sharded, what the foreign key management mode is and the error in the keyspace (if any).This query is intended to provide an easier way to look at the keyspace information as an alternative to looking at the
/debug/vschema
endpoint of vtgate and finding the required information.The query looks like the following when run from vtgate -
Related Issue(s)
managed
to vttestserver #14495 (comment)Checklist
Deployment Notes