Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary changes for recent PRs #14598

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add summary changes for recent PRs #14598

merged 1 commit into from
Nov 27, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the summary changes for the recent PRs -

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Documentation Component: General Changes throughout the code base labels Nov 24, 2023
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 24, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 24, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 24, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 24, 2023
@frouioui frouioui merged commit 4ddce5f into vitessio:main Nov 27, 2023
117 of 119 checks passed
@frouioui frouioui deleted the summary-changes branch November 27, 2023 15:20
deepthi
deepthi reviewed Nov 27, 2023
View reviewed changes
changelog/19.0/19.0.0/summary.md

#### <a id="fk-checks-vitess-aware"/>`FOREIGN_KEY_CHECKS` is now a Vitess Aware Variable

When VTGate receives a query to change the `FOREIGN_KEY_CHECKS` value for a session, instead of sending the value down to MySQL, VTGate now keeps track of the value and changes the queries by adding `SET_VAR(FOREIGN_KEY_CHECKS=On/Off)` style query optimizer hints wherever required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with MySQL 5.7? We haven't yet dropped support. Are we saying the new FK functionality is only supported on MySQL 8.0? That is acceptable, but we should state it clearly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! That is a very good point! That actually prompted #14631

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding docs changes as discussed - #14663

@GuptaManan100 GuptaManan100 mentioned this pull request Dec 4, 2023
Merged
4 tasks
ejortegau referenced this pull request in slackhq/vitess Dec 13, 2023
@GuptaManan100 @ejortegau
Add summary changes for recent PRs (#14598)
46d1c01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Documentation
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuptaManan100 @deepthi @harshit-gangal @frouioui