Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary changes to indicate MySQL 5.7 is EOL and Vitess is dropping support for it in v19 #14663

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add summary changes to indicate MySQL 5.7 is EOL and Vitess is dropping support for it in v19 #14663

merged 1 commit into from
Dec 4, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds the summary changes to indicate MySQL 5.7 is EOL and Vitess is dropping support for it in v19. This is in response to the discussion that was prompted from the review comment #14598 (comment)

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
summary: add summary changes to point out that MySQL 5.7 is eol and v…
75bc612 
…itess won't support it in v19

Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100 GuptaManan100 added Type: Documentation Component: General Changes throughout the code base labels Dec 4, 2023
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 4, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 4, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 4, 2023
GuptaManan100
GuptaManan100 commented Dec 4, 2023
View reviewed changes
changelog/19.0/19.0.0/summary.md
Comment on lines 5 to +6
- **[Major Changes](#major-changes)**
- **[Dropping Support for MySQL 5.7](#drop-support-mysql57)**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I make this its own heading? Even above Major Changes or is it okay being the first thing in Major Changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we write this? Afaik it would still be supported to import from MySQL 5.7 with MoveTables and with unmanaged tablets (similar to MariaDB)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's further down, so I guess that suffices?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay to leave it here, it is already the first item of Major Changes.

@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 4, 2023
@GuptaManan100 GuptaManan100 mentioned this pull request Dec 4, 2023
Merged
4 tasks
@frouioui frouioui merged commit 8520049 into vitessio:main Dec 4, 2023
119 of 122 checks passed
@frouioui frouioui deleted the mysql57-eol-summary branch December 4, 2023 17:41
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@GuptaManan100 @ejortegau
Add summary changes to indicate MySQL 5.7 is EOL and Vitess is droppi…
7506019 
…ng support for it in v19 (vitessio#14663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink left review comments

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Documentation
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuptaManan100 @dbussink @deepthi @frouioui