Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evalengine: Handle zero dates correctly #14610

Merged
merged 5 commits into from
Nov 27, 2023
Merged

evalengine: Handle zero dates correctly #14610

merged 5 commits into from
Nov 27, 2023

Conversation

dbussink
Copy link
Contributor

This removes the different configuration for testing to ensure we have the same settings as production defaults and subsequently fixes the failing evalengine issues.

Related Issue(s)

Fixes #14609

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@dbussink
evalengine: Handle zero dates correctly
f0c92b5 
This removes the different configuration for testing to ensure we have
the same settings as production defaults and subsequently fixes the
failing evalengine issues.

Signed-off-by: Dirkjan Bussink <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 27, 2023
@dbussink dbussink added Type: Bug Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 27, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 27, 2023
dbussink
dbussink commented Nov 27, 2023
View reviewed changes
go/vt/vtgate/vcursor_impl.go Outdated
@@ -211,6 +211,11 @@ func (vc *vcursorImpl) TimeZone() *time.Location {
return vc.safeSession.TimeZone()
}

func (vc *vcursorImpl) AllowZeroDate() bool {
// TODO: Implement detecting zero date
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshit-gangal Do you have a recommendation for how we can implement this here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need sql_mode representation which can provide these answers

@dbussink
Expose sql mode from the vcursor
4654ef5 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/handle-zero-date-evalengine branch from 8d08eb9 to a935164 Compare November 27, 2023 13:41
dbussink
dbussink commented Nov 27, 2023
View reviewed changes
go/mysql/endtoend/replication_test.go
// We have tests for zero dates, so we need to allow that for this session.
if _, err := dConn.ExecuteFetch("SET @@session.sql_mode=REPLACE(REPLACE(@@session.sql_mode, 'NO_ZERO_DATE', ''), 'NO_ZERO_IN_DATE', '')", 0, false); err != nil {
t.Fatal(err)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now needed since the tests try to insert zero dates and we need to test those, so they need to be allowed for this session here.

go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go

// default mysql flavor allows invalid dates: so disallow explicitly for this test
if err := env.Mysqld.ExecuteSuperQuery(context.Background(), "SET @@global.sql_mode=REPLACE(REPLACE(@@session.sql_mode, 'NO_ZERO_DATE', ''), 'NO_ZERO_IN_DATE', '')"); err != nil {
if _, err := conn.ExecuteFetch("SET @@session.sql_mode=REPLACE(REPLACE(@@session.sql_mode, 'NO_ZERO_DATE', ''), 'NO_ZERO_IN_DATE', '')", 0, false); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the logic here tried to set up the connection to allow zero dates. It didn't do that correctly though, but it accidentally worked since we didn't enforce zero dates in the past due to the different test MySQL config fixed in this PR.

The changes here actually fix the logic so we can insert zero dates for the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

shlomi-noach
shlomi-noach approved these changes Nov 27, 2023
View reviewed changes
go/vt/vttablet/tabletmanager/vreplication/vcopier_test.go

// default mysql flavor allows invalid dates: so disallow explicitly for this test
if err := env.Mysqld.ExecuteSuperQuery(context.Background(), "SET @@global.sql_mode=REPLACE(REPLACE(@@session.sql_mode, 'NO_ZERO_DATE', ''), 'NO_ZERO_IN_DATE', '')"); err != nil {
if _, err := conn.ExecuteFetch("SET @@session.sql_mode=REPLACE(REPLACE(@@session.sql_mode, 'NO_ZERO_DATE', ''), 'NO_ZERO_IN_DATE', '')", 0, false); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dbussink dbussink merged commit 5e23ddc into vitessio:main Nov 27, 2023
116 checks passed
@dbussink dbussink deleted the dbussink/handle-zero-date-evalengine branch November 27, 2023 14:38
harshit-gangal
harshit-gangal requested changes Nov 27, 2023
View reviewed changes
go/vt/vtgate/vcursor_impl.go
Comment on lines +214 to 220
func (vc *vcursorImpl) SQLMode() string {
// TODO: Implement return the current sql_mode.
// This is currently hardcoded to the default in MySQL 8.0.
return config.DefaultSQLMode
}

// MaxMemoryRows returns the maxMemoryRows flag value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have to honour the changed sql_mode stored in the session.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if any value is stored in session, if not then return the default value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshit-gangal I think this already is a strict improvement and we can do this separately. We used the wrong setting before (evalengine mismatched default sql_mode). I'll also open a feature request to track that.

@dbussink dbussink mentioned this pull request Nov 27, 2023
Open
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@dbussink @vmg @ejortegau
evalengine: Handle zero dates correctly (vitessio#14610)
0dc027d 
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Co-authored-by: Vicent Marti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal requested changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@vmg vmg vmg approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Evalengine changes to the evaluation engine Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: evalengine doesn't match default MySQL configuration for NO_ZERO_DATE
4 participants
@dbussink @vmg @shlomi-noach @harshit-gangal