Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txserializer: change log message based on dry run #14651

Merged
merged 2 commits into from
Jan 24, 2024
Merged

txserializer: change log message based on dry run #14651

merged 2 commits into from
Jan 24, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Nov 30, 2023 •
edited
Loading

Description

Change the hot row protection log message to describe whether or not transactions have been queued based on the dry run status.

Before

TestTxSerializer_ConcurrentTransactions

3 simultaneous transactions (3 in total) for the same row range (t1 where1) would have been queued.

❌ The transactions are actually queued.

TestTxSerializerDryRun

3 simultaneous transactions (3 in total) for the same row range (t1 where1) would have been queued.

✅ The transactions are not actually queued.

After

TestTxSerializer_ConcurrentTransactions

3 simultaneous transactions (3 in total) for the same row range (t1 where1) have been queued.

✅ The transactions are actually queued.

TestTxSerializerDryRun

3 simultaneous transactions (3 in total) for the same row range (t1 where1) would have been queued.

✅ The transactions are not actually queued.

Related Issue(s)

#14673

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

N/A

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 30, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 30, 2023
@tycol7
Change log message based on dry run
bb56e55 
Change the log message to reflect the dry run status; if not a dry run,
the message now says the transactions have been queued (as opposed to
the hypothetical "would have been queued" in the dry run).

Signed-off-by: Tyler Coleman <[email protected]>
@tycol7 tycol7 force-pushed the tdc/fix-dry-run-log-message branch from 91845c4 to bb56e55 Compare November 30, 2023 17:44
@tycol7 tycol7 changed the title Change log message based on dry run [Query consolidator] Change log message based on dry run Dec 4, 2023
@tycol7 tycol7 changed the title [Query consolidator] Change log message based on dry run [Hot row protection] Change log message based on dry run Dec 5, 2023
@maxenglander maxenglander added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 5, 2023
@maxenglander maxenglander changed the title [Hot row protection] Change log message based on dry run txserializer: change log message based on dry run Dec 5, 2023
@maxenglander maxenglander added Type: Bug and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 5, 2023
@tycol7 tycol7 marked this pull request as ready for review December 5, 2023 20:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 5, 2024
@tycol7
Keep alive
b31931d 
Signed-off-by: Tyler Coleman <[email protected]>
@github-actions github-actions bot removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 6, 2024
@harshit-gangal harshit-gangal removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Jan 9, 2024
@frouioui frouioui self-assigned this Jan 24, 2024
@frouioui frouioui merged commit dc4435e into vitessio:main Jan 24, 2024
99 of 100 checks passed
@frouioui frouioui deleted the tdc/fix-dry-run-log-message branch January 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

@frouioui frouioui

Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tycol7 @harshit-gangal @frouioui @maxenglander