Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txserializer: change log message based on dry run #14651

Merged
merged 2 commits into from
Jan 24, 2024
Merged

txserializer: change log message based on dry run #14651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb56e55
Change log message based on dry run
tycol7 Nov 30, 2023
b31931d
Keep alive
tycol7 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions go/vt/vttablet/tabletserver/txserializer/tx_serializer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,15 +273,18 @@ func (txs *TxSerializer) unlockLocked(key string, returnSlot bool) {
delete(txs.queues, key)

if q.max > 1 {
var formattedKey = key
var logMsg string

if txs.env.Config().SanitizeLogMessages {
logMsg = fmt.Sprintf("%v simultaneous transactions (%v in total) for the same row range (%v) would have been queued.", q.max, q.count, txs.sanitizeKey(key))
} else {
logMsg = fmt.Sprintf("%v simultaneous transactions (%v in total) for the same row range (%v) would have been queued.", q.max, q.count, key)
formattedKey = txs.sanitizeKey(key)
}

if txs.dryRun {
logMsg = fmt.Sprintf("%v simultaneous transactions (%v in total) for the same row range (%v) would have been queued.", q.max, q.count, formattedKey)
txs.logDryRun.Infof(logMsg)
} else {
logMsg = fmt.Sprintf("%v simultaneous transactions (%v in total) for the same row range (%v) have been queued.", q.max, q.count, formattedKey)
txs.log.Infof(logMsg)
}
}
Expand Down
Loading