Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: do not allocate in parseOKPacket #15067

Merged
merged 1 commit into from
Jan 29, 2024

mysql: do not allocate PacketOK when parsing from connection

9966086
Select commit
Loading
Failed to load commit list.
Merged

mysql: do not allocate in parseOKPacket #15067

mysql: do not allocate PacketOK when parsing from connection
9966086
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 29, 2024 in 1s

57.14% of diff hit (target 47.29%)

View this Pull Request on Codecov

57.14% of diff hit (target 47.29%)

Annotations

Check warning on line 240 in go/cmd/vtctldclient/command/root.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/root.go#L240 

Added line #L240 was not covered by tests

Check warning on line 125 in go/cmd/vtctldclient/command/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/schema.go#L125 

Added line #L125 was not covered by tests

Check warning on line 99 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L98-L99 

Added lines #L98 - L99 were not covered by tests

Check warning on line 107 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L106-L107 

Added lines #L106 - L107 were not covered by tests

Check warning on line 113 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L112-L113 

Added lines #L112 - L113 were not covered by tests

Check warning on line 90 in go/mysql/datetime/mydate.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/datetime/mydate.go#L87-L90 

Added lines #L87 - L90 were not covered by tests

Check warning on line 212 in go/mysql/flavor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/flavor.go#L212 

Added line #L212 was not covered by tests

Check warning on line 507 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L507 

Added line #L507 was not covered by tests

Check warning on line 518 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L518 

Added line #L518 was not covered by tests

Check warning on line 522 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L522 

Added line #L522 was not covered by tests

Check warning on line 525 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L525 

Added line #L525 was not covered by tests

Check warning on line 315 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L314-L315 

Added lines #L314 - L315 were not covered by tests

Check warning on line 352 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L351-L352 

Added lines #L351 - L352 were not covered by tests

Check warning on line 357 in go/vt/mysqlctl/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/schema.go#L356-L357 

Added lines #L356 - L357 were not covered by tests

Check warning on line 134 in go/vt/schemadiff/column.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/column.go#L134 

Added line #L134 was not covered by tests

Check warning on line 138 in go/vt/schemadiff/column.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/column.go#L138 

Added line #L138 was not covered by tests

Check warning on line 144 in go/vt/schemadiff/column.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/column.go#L143-L144 

Added lines #L143 - L144 were not covered by tests

Check warning on line 161 in go/vt/schemadiff/column.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/column.go#L161 

Added line #L161 was not covered by tests

Check warning on line 165 in go/vt/schemadiff/column.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/column.go#L165 

Added line #L165 was not covered by tests

Check warning on line 121 in go/vt/schemadiff/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema.go#L121 

Added line #L121 was not covered by tests

Check warning on line 968 in go/vt/schemadiff/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema.go#L967-L968 

Added lines #L967 - L968 were not covered by tests

Check warning on line 357 in go/vt/schemadiff/schema_diff.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema_diff.go#L356-L357 

Added lines #L356 - L357 were not covered by tests

Check warning on line 131 in go/vt/schemadiff/table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/table.go#L130-L131 

Added lines #L130 - L131 were not covered by tests

Check warning on line 352 in go/vt/schemadiff/table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/table.go#L351-L352 

Added lines #L351 - L352 were not covered by tests

Check warning on line 417 in go/vt/schemadiff/table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/table.go#L417 

Added line #L417 was not covered by tests
View more details on Codecov