Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: do not allocate in parseOKPacket #15067

Merged
merged 1 commit into from
Jan 29, 2024

mysql: do not allocate PacketOK when parsing from connection

9966086
Select commit
Loading
Failed to load commit list.
Merged

mysql: do not allocate in parseOKPacket #15067

mysql: do not allocate PacketOK when parsing from connection
9966086
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2024 in 0s

47.65% (+0.35%) compared to eddb39e

View this Pull Request on Codecov

47.65% (+0.35%) compared to eddb39e

Details

Codecov Report

Attention: 480 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (9966086) 47.65%.
Report is 71 commits behind head on main.

Files Patch % Lines
...vt/vtgate/planbuilder/operators/sharded_routing.go 0.00% 42 Missing ⚠️
go/vt/vtgate/planbuilder/operators/delete.go 0.00% 32 Missing ⚠️
go/vt/vtgate/evalengine/cached_size.go 0.00% 31 Missing ⚠️
.../vtgate/planbuilder/operators/delete_with_input.go 0.00% 31 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 25 Missing ⚠️
go/vt/vtgate/engine/delete_with_input.go 53.70% 23 Missing and 2 partials ⚠️
...tgate/planbuilder/operators/aggregation_pushing.go 0.00% 25 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 0.00% 20 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 0.00% 19 Missing ⚠️
go/vt/vtgate/evalengine/expr_tuple_bvar.go 62.50% 14 Missing and 4 partials ⚠️
... and 48 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15067      +/-   ##
==========================================
+ Coverage   47.29%   47.65%   +0.35%     
==========================================
  Files        1137     1151      +14     
  Lines      238684   239760    +1076     
==========================================
+ Hits       112895   114263    +1368     
+ Misses     117168   116893     -275     
+ Partials     8621     8604      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov