Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parser to allow multiple strings one after the other #15076

Merged
merged 2 commits into from
Jan 30, 2024

Merge remote-tracking branch 'upstream/main' into fix-multiple-strings

8dd4678
Select commit
Loading
Failed to load commit list.
Merged

Fix the parser to allow multiple strings one after the other #15076

Merge remote-tracking branch 'upstream/main' into fix-multiple-strings
8dd4678
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2024 in 0s

47.69% (+0.39%) compared to eddb39e

View this Pull Request on Codecov

47.69% (+0.39%) compared to eddb39e

Details

Codecov Report

Attention: 548 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (8dd4678) 47.69%.
Report is 77 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/evalengine/cached_size.go 0.00% 41 Missing ⚠️
go/vt/vtgate/planbuilder/operators/delete.go 0.00% 32 Missing ⚠️
.../vtgate/planbuilder/operators/delete_with_input.go 0.00% 31 Missing ⚠️
.../vtgate/planbuilder/operators/horizon_expanding.go 0.00% 31 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 25 Missing ⚠️
go/vt/vtgate/engine/delete_with_input.go 53.70% 23 Missing and 2 partials ⚠️
...tgate/planbuilder/operators/aggregation_pushing.go 0.00% 25 Missing ⚠️
go/vt/mysqlctl/backupengine.go 0.00% 24 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 4.54% 21 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 0.00% 21 Missing ⚠️
... and 55 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15076      +/-   ##
==========================================
+ Coverage   47.29%   47.69%   +0.39%     
==========================================
  Files        1137     1155      +18     
  Lines      238684   240151    +1467     
==========================================
+ Hits       112895   114542    +1647     
+ Misses     117168   117010     -158     
+ Partials     8621     8599      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov