Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Update Multi Table #15211

Merged
merged 12 commits into from
Feb 14, 2024
Merged

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 12, 2024

Description

This PR adds support for update statements with multi-table references.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 12, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 12, 2024
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 13, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (14473b9) 67.34% compared to head (3d456e8) 67.43%.
Report is 5 commits behind head on main.

❗ Current head 3d456e8 differs from pull request most recent head a52c54a. Consider uploading reports for the commit a52c54a to get more accurate results

Files Patch % Lines
go/vt/sqlparser/ast_funcs.go 54.83% 28 Missing ⚠️
go/vt/vtgate/planbuilder/operators/SQL_builder.go 96.22% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/update.go 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15211      +/-   ##
==========================================
+ Coverage   67.34%   67.43%   +0.08%     
==========================================
  Files        1560     1560              
  Lines      192571   192807     +236     
==========================================
+ Hits       129695   130011     +316     
+ Misses      62876    62796      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal merged commit a0ce8bc into vitessio:main Feb 14, 2024
100 checks passed
@harshit-gangal harshit-gangal deleted the upd-multi branch February 14, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for Update with multi table reference
3 participants