Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: improve reliability of log management #15374

Merged
merged 19 commits into from
Mar 10, 2024

Avoid floats and type conversions

9a0e780
Select commit
Loading
Failed to load commit list.
Merged

VReplication: improve reliability of log management #15374

Avoid floats and type conversions
9a0e780
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 29, 2024 in 0s

73.21% of diff hit (target 65.43%)

View this Pull Request on Codecov

73.21% of diff hit (target 65.43%)

Annotations

Check warning on line 136 in go/vt/binlog/binlogplayer/dbclient.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/binlog/binlogplayer/dbclient.go#L135-L136

Added lines #L135 - L136 were not covered by tests

Check warning on line 252 in go/vt/binlog/binlogplayer/mock_dbclient.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/binlog/binlogplayer/mock_dbclient.go#L249-L252

Added lines #L249 - L252 were not covered by tests

Check warning on line 927 in go/vt/vtctl/workflow/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L927

Added line #L927 was not covered by tests

Check warning on line 95 in go/vt/vttablet/tabletmanager/vreplication/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/utils.go#L94-L95

Added lines #L94 - L95 were not covered by tests

Check warning on line 110 in go/vt/vttablet/tabletmanager/vreplication/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/utils.go#L109-L110

Added lines #L109 - L110 were not covered by tests

Check warning on line 118 in go/vt/vttablet/tabletmanager/vreplication/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/utils.go#L118

Added line #L118 was not covered by tests

Check warning on line 257 in go/vt/vttablet/tabletmanager/vreplication/vcopier.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/vcopier.go#L257

Added line #L257 was not covered by tests

Check warning on line 263 in go/vt/vttablet/tabletmanager/vreplication/vcopier.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/vcopier.go#L263

Added line #L263 was not covered by tests

Check warning on line 265 in go/vt/vttablet/tabletmanager/vreplication/vcopier.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletmanager/vreplication/vcopier.go#L265

Added line #L265 was not covered by tests