-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Durabler
interface methods public
#15548
Make Durabler
interface methods public
#15548
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15548 +/- ##
==========================================
- Coverage 65.78% 65.78% -0.01%
==========================================
Files 1561 1561
Lines 194838 194838
==========================================
- Hits 128183 128174 -9
- Misses 66655 66664 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We also need approval from @GuptaManan100 as the primary author/maintainer of these files.
@GuptaManan100 should we add this to the release notes for v20? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! The changes look good to me, but we do need to add a section describing this change to the interface in changelog/20.0/20.0.0/summary.md
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@GuptaManan100 / @deepthi sounds good, changelog added 👍. Edits are appreciated |
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
…hods Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
…cy (#266) * `slack-vitess-r15.0.5`: add `slack_cross_cell` custom durability policy Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy again Signed-off-by: Tim Vaillancourt <[email protected]> * Use tag Signed-off-by: Tim Vaillancourt <[email protected]> * use v0.15.1 Signed-off-by: Tim Vaillancourt <[email protected]> * update shim Signed-off-by: Tim Vaillancourt <[email protected]> * Make `Durabler` interface methods public (vitessio#15548) Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> * Update `slack_cross_cell` shim Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy again Signed-off-by: Tim Vaillancourt <[email protected]> * Allow private go module from vitess-additions repo Signed-off-by: Tim Vaillancourt <[email protected]> * Fix typo Signed-off-by: Tim Vaillancourt <[email protected]> * Missing non-template update Signed-off-by: Tim Vaillancourt <[email protected]> * Missing non-template update Signed-off-by: Tim Vaillancourt <[email protected]> * Missing non-template update, pt 3 Signed-off-by: Tim Vaillancourt <[email protected]> * Fix docker tests Signed-off-by: Tim Vaillancourt <[email protected]> * make proto Signed-off-by: Tim Vaillancourt <[email protected]> * fix upgrade/downgrade tests Signed-off-by: Tim Vaillancourt <[email protected]> * Update all the Go dependencies (vitessio#11741) * Update all the Go dependencies This seems to work for the basics just fine, so let's have CI take a run at this as well to update these. Only one small update to the Azure blob storage handling seems needed so far. Signed-off-by: Dirkjan Bussink <[email protected]> * Use correct proto comparisons We're using `reflect.DeepEqual` or `testify` helpers that essentially use that in a number of places are comparing protobufs. This is not supported though, protobufs are not comparable with `reflect.DeepEqual`. This is exposed because of the tiny patch bump of protobuf which changes some internal optimization of how it initializes protobufs that breaks all this. Instead, move to the appropriate helpers here. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> * Resolve signature mismatch Signed-off-by: Tim Vaillancourt <[email protected]> * revert protobuf version Signed-off-by: Tim Vaillancourt <[email protected]> * revert protobuf version, pt 2 Signed-off-by: Tim Vaillancourt <[email protected]> * Revert "Update all the Go dependencies (vitessio#11741)" This reverts commit 18faa1e. * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
* Make `Durabler` interface methods public (vitessio#15548) Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> * Load `--grpc_auth_static_client_creds` file once (vitessio#15030) Signed-off-by: Tim Vaillancourt <[email protected]> * Limit concurrent creation of healthcheck gRPC connections (vitessio#15053) Signed-off-by: Tim Vaillancourt <[email protected]> * Filter by keyspace earlier in `tabletgateway`s `WaitForTablets(...)` (vitessio#15347) Signed-off-by: Tim Vaillancourt <[email protected]> * Use slack-15.0 as previous release Signed-off-by: Tim Vaillancourt <[email protected]> * empty commit Signed-off-by: Tim Vaillancourt <[email protected]> * force ci to run * Update GH Action runners Signed-off-by: Tim Vaillancourt <[email protected]> * test templates Signed-off-by: Tim Vaillancourt <[email protected]> * set GH access token in build Signed-off-by: Tim Vaillancourt <[email protected]> * Fix reparent old tests Signed-off-by: Tim Vaillancourt <[email protected]> * Remove CIs we don't need Signed-off-by: Tim Vaillancourt <[email protected]> * Remove CIs we don't need again Signed-off-by: Tim Vaillancourt <[email protected]> * Add private repo setup to upgrade_downgrade_test_backups_e2e.yml Signed-off-by: Tim Vaillancourt <[email protected]> * Add private repo setup to more CI Signed-off-by: Tim Vaillancourt <[email protected]> * remove CI skip logic for upstream stuff Signed-off-by: Tim Vaillancourt <[email protected]> * CODEOWNERS Signed-off-by: Tim Vaillancourt <[email protected]> * [release-19.0] Add timeout to all the contexts used for RPC calls in vtorc (vitessio#15991) (vitessio#16103) Signed-off-by: Manan Gupta <[email protected]> * `slack-vitess-r15.0.5`: forward-port consul topo limits PR #111 (#297) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <[email protected]> * fix e2e test Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> * update vtcombo e2e Signed-off-by: Tim Vaillancourt <[email protected]> * Fix err with installing percona-xtrabackup-24 Signed-off-by: Tim Vaillancourt <[email protected]> * `slack-vitess-r15.0.5`: fix races in `Unit Test (Race)` CI, fix "old" reparent CIs (#356) * update vtcombo e2e test Signed-off-by: Tim Vaillancourt <[email protected]> * Fix bad merge conflict fix Signed-off-by: Tim Vaillancourt <[email protected]> * go mod tidy Signed-off-by: Tim Vaillancourt <[email protected]> * update vtcombo e2e test again Signed-off-by: Tim Vaillancourt <[email protected]> * [release-19.0] Upgrade the Golang version to `go1.22.5` (vitessio#16322) Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> * merge conflict fixes Signed-off-by: Tim Vaillancourt <[email protected]> * make vtadmin_web_proto_types Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: GitHub <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: vitess-bot <[email protected]> Co-authored-by: frouioui <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Description
This PR implements an open RFC for moving the
Durabler
interface from thereparentutil
package to public methods so it is easier to integrate Durability Policies from external packagesRelated Issue(s)
RFC: #15544
Checklist
Deployment Notes