Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #15649

Closed
wants to merge 2 commits into from
Closed

Update dependencies #15649

wants to merge 2 commits into from

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 4, 2024

Description

We are using golang.org/x/net, and there is a security problem with the v0.22.0 version, so in this PR I've updated all our dependencies to the latest.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@systay
Update go dependencies
ed64c48 
Signed-off-by: Andres Taylor <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 4, 2024
@systay systay added Type: Internal Cleanup Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 4, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 4, 2024
@systay systay mentioned this pull request Apr 4, 2024
Merged
5 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.12%. Comparing base (696fe0e) to head (a3dbc2b).
Report is 196 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/fakerpcvtgateconn/conn.go 0.00% 1 Missing ⚠️
go/vtbench/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15649      +/-   ##
==========================================
+ Coverage   67.41%   68.12%   +0.70%     
==========================================
  Files        1560     1556       -4     
  Lines      192752   195024    +2272     
==========================================
+ Hits       129952   132858    +2906     
+ Misses      62800    62166     -634

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink
Fix GRPC deprecations
a3dbc2b 
This change means "opening" a connection no longer really already dials
to the actual other side, so we should see if this has any other
significant effects if we instead dial on first request.

The old stuff is deprecated though, so we have to bite the bullet at
some point. Alternatively, we essentially copy this initial connect
logic into our side instead.

Signed-off-by: Dirkjan Bussink <[email protected]>
@deepthi deepthi mentioned this pull request Apr 17, 2024
Closed
@deepthi
Copy link
Member

deepthi commented Apr 17, 2024

Closing in favor of #15708. We can pick the grpc changes into that PR.

@deepthi deepthi closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@dbussink dbussink Awaiting requested review from dbussink

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@systay @deepthi @dbussink @harshit-gangal