Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Golang Dependencies #15708

Closed
wants to merge 1 commit into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 15, 2024

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....
@vitessio/release

@github-actions github-actions bot added Component: General Changes throughout the code base dependencies Pull requests that update a dependency file go Type: Internal Cleanup labels Apr 15, 2024
Copy link
Contributor

vitess-bot bot commented Apr 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 15, 2024
@deepthi deepthi requested review from dbussink and removed request for systay, ajm188, harshit-gangal and rohit-nayak-ps April 15, 2024 03:21
@deepthi deepthi added Type: Dependencies Dependency updates and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required dependencies Pull requests that update a dependency file Type: Internal Cleanup labels Apr 15, 2024
@deepthi
Copy link
Member

deepthi commented Apr 17, 2024

Probably need this fix to get tests passing?
If we fix this PR, we can merge it and close #15649

@deepthi deepthi mentioned this pull request Apr 17, 2024
5 tasks
@frouioui frouioui requested a review from a team April 17, 2024 16:50
Signed-off-by: GitHub <[email protected]>
@github-actions github-actions bot force-pushed the upgrade-go-deps-on-main branch from d308144 to 7236dec Compare April 17, 2024 17:00
@frouioui
Copy link
Member

Closing this in favor of #15743. I will apply the suggestion highlighted in her most recent comment in #15743.

@frouioui frouioui closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base go Type: Dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants