-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign and tag the release team for go update/upgrade auto PRs #15737
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Oh I forgot one thing. |
title: "Upgrade the Golang Dependencies" | ||
body: | | ||
This Pull Request updates all the Golang dependencies to their latest version using `go get -u ./...`. | ||
|
||
cc @vitessio/release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 60 should change to Dependencies
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via 457977d
Signed-off-by: Florent Poinsard <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15737 +/- ##
==========================================
+ Coverage 68.38% 68.42% +0.03%
==========================================
Files 1556 1556
Lines 195361 195418 +57
==========================================
+ Hits 133598 133708 +110
+ Misses 61763 61710 -53 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
This PR changes the automatic golang deps update and version upgrade to tag the
@vitessio/release
team in the reviewers list and in the PRs' descriptions.To do this, I have generated a PAT for the @vitess-bot account and used it in the create-pull-request action. Here is what a PR for the update dependencies looks like now: #15743