Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign and tag the release team for go update/upgrade auto PRs #15737

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Assign and tag the release team for go update/upgrade auto PRs #15737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b295e5
Assign and tag the release team for go update/upgrade auto PRs
frouioui Apr 17, 2024
6625f82
More debug
frouioui Apr 17, 2024
5541809
Use PAT to create PRs and use team-reviewers
frouioui Apr 17, 2024
3a794a1
Try tagging team with their short name
frouioui Apr 17, 2024
577578e
Remove env field and use token field instead
frouioui Apr 17, 2024
eba4319
Remove debug code
frouioui Apr 17, 2024
78648c1
Use proper branch name
frouioui Apr 17, 2024
457977d
Fix review suggestions
frouioui Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/update_golang_dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,19 @@ jobs:
- name: Create Pull Request
uses: peter-evans/create-pull-request@v4
with:
token: ${{ secrets.CREATE_PR_VITESS_BOT }}
branch: "upgrade-go-deps-on-main"
commit-message: "upgrade go deps"
signoff: true
delete-branch: true
team-reviewers: Release
title: "Upgrade the Golang Dependencies"
body: |
This Pull Request updates all the Golang dependencies to their latest version using `go get -u ./...`.

cc @vitessio/release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 60 should change to Dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 457977d

base: main
labels: |
go
dependencies
Component: General
Type: Internal Cleanup
Type: Dependencies
4 changes: 4 additions & 0 deletions .github/workflows/update_golang_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,12 @@ jobs:
if: steps.detect-and-update.outputs.create-pr == 'true'
uses: peter-evans/create-pull-request@v4
with:
token: ${{ secrets.CREATE_PR_VITESS_BOT }}
branch: "upgrade-go-to-${{steps.detect-and-update.outputs.go-version}}-on-${{ matrix.branch }}"
commit-message: "bump go version to go${{steps.detect-and-update.outputs.go-version}}"
signoff: true
delete-branch: true
team-reviewers: Release
title: "[${{ matrix.branch }}] Upgrade the Golang version to `go${{steps.detect-and-update.outputs.go-version}}`"
body: |
This Pull Request bumps the Golang version to `go${{steps.detect-and-update.outputs.go-version}}` and the bootstrap version to `${{steps.detect-and-update.outputs.bootstrap-version}}`.
Expand All @@ -81,6 +83,8 @@ jobs:
- [ ] Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
- [ ] Update the `./.github/workflows/*.yml` files with the newer Golang version, the bot cannot handle that due to permissions.
- To accomplish this, run the following: `go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=${{steps.detect-and-update.outputs.go-version}}`

cc @vitessio/release
base: ${{ matrix.branch }}
labels: |
Skip CI
Expand Down
Loading