-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mysqlbinlog
and xtrabackup
to the vitess/lite
image
#15775
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15775 +/- ##
==========================================
+ Coverage 68.43% 68.44% +0.01%
==========================================
Files 1556 1558 +2
Lines 195433 195822 +389
==========================================
+ Hits 133743 134035 +292
- Misses 61690 61787 +97 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Actually I will try to add |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
mysqlbinlog
to the vitess/lite
imagemysqlbinlog
and xtrabackup
to the vitess/lite
image
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Nice! Thank you |
Description
This Pull Request modifies the
vitess/lite
image by basing it on themysql80
bootstrap image instead ofcommon
and copying themysqlbinlog
image from the base image. It also now installsxtrabackup
on it.The image size is slightly increased from
1.22GB
to1.49GB
:Cleanups
I am also removing the lite ubi7 and ubi8 images in this PR as they don't seem to be used and @aquarapid (who added them initially) suggested.
We never built or pushed the
.testing
variant and can be replaced byvttestserver
which we already build and push for every commit tomain
and tag. This Dockerfile is now removed.With only one Dockerfile left in
lite
, the Makefile is also simplified.Related Issue(s)
mysqlbinlog
andxtrabackup
missing fromvitess/lite
#15776Checklist
Deployment Notes