Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Insert with row alias #15790

Merged
merged 8 commits into from
Apr 29, 2024

split the rowalias table collector method to smaller methods

d1c396b
Select commit
Loading
Failed to load commit list.
Merged

feat: Add support for Insert with row alias #15790

split the rowalias table collector method to smaller methods
d1c396b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 26, 2024 in 1s

68.44% (-0.01%) compared to 96b1419, passed because coverage increased by +0.00% when compared to adjusted base (68.43%)

View this Pull Request on Codecov

68.44% (-0.01%) compared to 96b1419, passed because coverage increased by +0.00% when compared to adjusted base (68.43%)

Details

Codecov Report

Attention: Patch coverage is 93.70629% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (96b1419) to head (d1c396b).
Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/semantics/table_collector.go 92.78% 7 Missing ⚠️
go/vt/vtgate/engine/insert.go 87.50% 1 Missing ⚠️
go/vt/vtgate/semantics/vtable.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15790      +/-   ##
==========================================
- Coverage   68.44%   68.44%   -0.01%     
==========================================
  Files        1558     1558              
  Lines      195822   196129     +307     
==========================================
+ Hits       134032   134233     +201     
- Misses      61790    61896     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.