Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog 20.0: Fix broken links #16048

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Changelog 20.0: Fix broken links #16048

merged 1 commit into from
Jun 6, 2024

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jun 4, 2024 •
edited
Loading

Description

Somewhat late seeing that we code-freezed, this PR fixes a couple broken links in the 20.0 changelog.

I've also reviewed the PR for spell checking, it looks good.

To be backported to release-20.0 and then to release-20.0-rc

Related Issue(s)

#16010

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach requested a review from a team June 4, 2024 08:27
@shlomi-noach shlomi-noach requested a review from deepthi as a code owner June 4, 2024 08:27
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 4, 2024
@shlomi-noach shlomi-noach added Backport to: release-20.0-rc Backport to: release-20.0 Needs to be backport to release-20.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 4, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 4, 2024
frouioui
frouioui approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@shlomi-noach shlomi-noach requested a review from a team June 4, 2024 14:06
@frouioui frouioui requested a review from a team June 4, 2024 14:20
@frouioui frouioui mentioned this pull request Jun 4, 2024
Closed
49 tasks
@shlomi-noach shlomi-noach merged commit 307b290 into vitessio:main Jun 6, 2024
104 checks passed
@shlomi-noach shlomi-noach deleted the fix-changelog-20.0-links branch June 6, 2024 14:08
vitess-bot pushed a commit that referenced this pull request Jun 6, 2024
@vitess-bot
Changelog 20.0: Fix broken links (#16048)
709de6d 
Signed-off-by: Shlomi Noach <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Jun 6, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Jun 6, 2024
@vitess-bot
Changelog 20.0: Fix broken links (#16048)
c053441 
Signed-off-by: Shlomi Noach <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Jun 6, 2024
Merged
shlomi-noach pushed a commit that referenced this pull request Jun 9, 2024
@vitess-bot
[release-20.0] Changelog 20.0: Fix broken links (#16048) (#16076)
be83207 
Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Jun 10, 2024
@vitess-bot
[release-20.0-rc] Changelog 20.0: Fix broken links (#16048) (#16075)
11f449c 
Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Component: Documentation docs related issues/PRs Type: Documentation
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @systay @frouioui