Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planner cleaning: cleanup and refactor #16569

Merged
merged 11 commits into from
Aug 15, 2024

review comments

4451af6
Select commit
Loading
Failed to load commit list.
Merged

Planner cleaning: cleanup and refactor #16569

review comments
4451af6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 15, 2024 in 1s

68.83% (-0.03%) compared to cc68dd5

View this Pull Request on Codecov

68.83% (-0.03%) compared to cc68dd5

Details

Codecov Report

Attention: Patch coverage is 97.65625% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (cc68dd5) to head (4451af6).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/aggregator.go 94.44% 1 Missing ⚠️
go/vt/vtgate/planbuilder/operators/apply_join.go 83.33% 1 Missing ⚠️
...vtgate/planbuilder/operators/projection_pushing.go 96.55% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16569      +/-   ##
==========================================
- Coverage   68.85%   68.83%   -0.03%     
==========================================
  Files        1557     1557              
  Lines      199891   199983      +92     
==========================================
+ Hits       137644   137659      +15     
- Misses      62247    62324      +77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov