VTAdmin: Support for Workflow Actions

[beingnoble03]

Description

This PR adds support for workflow complete, switchtraffic, reversetraffic and cancel operation from VTAdmin.

Related Issue(s)

• VTAdmin: Enhance VReplication functionality in vtadmin UI #11690

Screenshots

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 3.61446% with 80 lines in your changes missing coverage. Please review.

Project coverage is 69.36%. Comparing base (8b37c52) to head (94ab67f).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtadmin/http/workflows.go	0.00%	42 Missing ⚠️
go/vt/vtadmin/api.go	7.50%	37 Missing ⚠️
go/vt/vtadmin/rbac/config.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16816      +/-   ##
==========================================
- Coverage   69.41%   69.36%   -0.05%     
==========================================
  Files        1570     1570              
  Lines      203929   204053     +124     
==========================================
- Hits       141551   141544       -7     
- Misses      62378    62509     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

Looks good! I played around with it and it works as expected. The pop-up window on complete that presents you with the relevant options is really nice.

The only surprise is that we do not have this for Reshard too since it's otherwise roughly equivalent support-wise on main.

[mattlord]

Any reason we're doing movetables and not reshard? Looks like this PR branch does not appear to have the Reshard work from #16903, so that may be why. Can we add it here so that we have some uniformity? We can also do it in a follow-up if needed.

[mattlord]

Same for Materialize, which we'll have shortly: #16941

[beingnoble03]

I think complete can be done for Reshard. I can do that in a follow-up PR.

[beingnoble03]

Updated the branch with latest changes, and tested the changes locally after the merge.