-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin: Support for Materialize
Create
#16941
VTAdmin: Support for Materialize
Create
#16941
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16941 +/- ##
==========================================
- Coverage 69.41% 69.38% -0.04%
==========================================
Files 1570 1570
Lines 203948 203989 +41
==========================================
- Hits 141576 141543 -33
- Misses 62372 62446 +74 ☔ View full report in Codecov by Sentry. |
This looks great! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in my testing! Would be nice to incorporate cancel/delete here if possible: #16816
Can be done in a later follow-up though.
Description
This PR adds support to create a
Materialize
workflow directly from VTAdmin. Contains both API and Web changes.Related Issue(s)
Screenshots
Checklist
Deployment Notes