-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run plan tests in end to end configuration #17117
Conversation
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Nice! This will be a great help in making sure we catch planner issues earlier. 👍 |
fdc6a91
to
4eb7aef
Compare
Signed-off-by: Harshit Gangal <[email protected]>
4eb7aef
to
7864e3a
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
8b1aee2
to
27d8dc9
Compare
Signed-off-by: Harshit Gangal <[email protected]>
27d8dc9
to
6b0c533
Compare
Signed-off-by: Harshit Gangal <[email protected]>
d24f46e
to
bc938cd
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17117 +/- ##
==========================================
+ Coverage 67.41% 67.45% +0.03%
==========================================
Files 1576 1578 +2
Lines 253417 253541 +124
==========================================
+ Hits 170846 171028 +182
+ Misses 82571 82513 -58 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Thank you @harshit-gangal for picking this up and running with it. It looks great now. I can't accept my own PR, but if I could, I would! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! Any plan on running more plan tests in E2E?
This should be done as and when the planner is modified. |
Description
We’ve frequently encountered planner tests that assert faulty query plans, which would crash if executed directly on MySQL. This PR enhances testing by running these queries, with data, against both MySQL and Vitess, ensuring the results are consistent and correct across both systems.
Related Issue(s)
Checklist