Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run plan tests in end to end configuration #17117

Merged
merged 13 commits into from
Dec 10, 2024
Prev Previous commit
Next Next commit
added a todo comment
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
  • Loading branch information
harshit-gangal committed Dec 7, 2024
commit cc9d853daa573da272aca0da40f112416962a618
1 change: 1 addition & 0 deletions go/vt/vtgate/engine/plan_description.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ func (pd PrimitiveDescription) Equals(other PrimitiveDescription) string {
return fmt.Sprintf("OperatorType: %v != %v", pd.OperatorType, other.OperatorType)
}

// TODO (harshit): enable this to compare keyspace as well
// switch {
// case pd.Keyspace == nil && other.Keyspace == nil:
// // do nothing
Expand Down
Loading