-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness in TestReadTransactionStatus
#17277
Fix flakiness in TestReadTransactionStatus
#17277
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17277 +/- ##
==========================================
+ Coverage 67.37% 67.40% +0.02%
==========================================
Files 1573 1573
Lines 253113 253136 +23
==========================================
+ Hits 170538 170614 +76
+ Misses 82575 82522 -53 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the appropriate code owners for these new test folders?
Signed-off-by: Manan Gupta <[email protected]>
TestReadTransactionStatus
Description
This PR fixes flakiness in
TestReadTransactionStatus
. When we start a commit in a separate go routine, and then wait for 1 second for it to show up in the unresolved list, there is a race condition. If the commit starts a little bit later because the goroutine is not immediately scheduled, when we try to read the list of unresolved transactions with an abandoed age of 1 second, we might not read it, because its only like 0.9 seconds old.This PR fixes this issue.
Related Issue(s)
Checklist
Deployment Notes