Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest Nodejs LTS and NPM #17606

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update to latest Nodejs LTS and NPM #17606

wants to merge 3 commits into from
+4,616 −3,701

Conversation

dbussink
Copy link
Contributor

This bumps to the latest Node LTS version with 22 and to NPM 11. Also bumps Vite to the latest as well to address a Dependanbot alert.

Related Issue(s)

Fixes https://github.com/vitessio/vitess/security/dependabot/401

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 22, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 22, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 22, 2025
@dbussink dbussink added dependencies Pull requests that update a dependency file and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 22, 2025
GrahamCampbell
GrahamCampbell suggested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/binaries/vtadmin/Dockerfile needs updating, too.

@dbussink dbussink force-pushed the dbussink/update-nodejs-npm branch from ac6e953 to 0df7ff6 Compare January 22, 2025 13:59
@dbussink
Copy link
Contributor Author

docker/binaries/vtadmin/Dockerfile needs updating, too.

Good catch, done!

@dbussink
Update to latest Nodejs LTS and NPM
507dcc2 
This bumps to the latest Node LTS version with 22 and to NPM 11. Also
bumps Vite to the latest as well to address a Dependanbot alert.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink
Update to Node 22 in container too
4a1fdff 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink
Add changelog entry
1b263f7 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/update-nodejs-npm branch from 1bd000e to 1b263f7 Compare January 22, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Build/CI Component: VTAdmin VTadmin interface dependencies Pull requests that update a dependency file Type: CI/Build
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @GrahamCampbell @frouioui