Check the write permission on /sys/power/disk when hibernate
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #55. |
| @@ -36,7 +36,10 @@ case "$ZZZ_MODE" in | |||
| hibernate) grep -q disk /sys/power/state || fail "hibernate not supported";; | |||
| esac | |||
|
|
|||
| test -w /sys/power/state || fail "sleep permission denied" | |||
| if ! [ -w /sys/power/state ] || { | |||
There was a problem hiding this comment.
! ... || is a double-negative and makes it highly painful to understand what the logic is supposed to be in this if statement. nested ifs would make this much more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the permission on
/sys/power/stateis tested, which may cause an unintended operating mode of hibernation if/sys/power/diskis not writable. With this PR, the permission on/sys/power/diskis also be tested.closes: #55