Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the write permission on /sys/power/disk when hibernate #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check the write permission on /sys/power/disk when hibernate #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion zzz
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ case "$ZZZ_MODE" in
hibernate) grep -q disk /sys/power/state || fail "hibernate not supported";;
esac

test -w /sys/power/state || fail "sleep permission denied"
if ! [ -w /sys/power/state ] || {
Copy link
Member

@classabbyamp classabbyamp Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! ... || is a double-negative and makes it highly painful to understand what the logic is supposed to be in this if statement. nested ifs would make this much more readable

! [ -w /sys/power/disk ] && [ "$ZZZ_MODE" = hibernate ];}; then
fail "sleep permission denied"
fi

(
flock -n 9 || fail "another instance of zzz is running"
Expand Down