Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflicts in pyproject.toml #1548

Closed
wants to merge 2 commits into from
Closed

Fix dependency conflicts in pyproject.toml #1548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b9eda
Fix dependency conflicts in pyproject.toml
dgmcdona Jan 13, 2025
055c8db
Downgrade required versions of sphinx + related for 3.8
dgmcdona Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Downgrade required versions of sphinx + related for 3.8 
This lowers the required versions of sphinx and sphinx-autodoc-typehints
to the highest versions that still support Python 3.8.
  • Loading branch information
@dgmcdona
dgmcdona committed Jan 14, 2025
commit 055c8dbc1272c5b4edc87ae2a6a790638ca8db58
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ more details.

## Installing

Volatility 3 requires Python 3.10.0 or later and is published on the [PyPi registry](https://pypi.org/project/volatility3).
Volatility 3 requires Python 3.8.0 or later and is published on the [PyPi registry](https://pypi.org/project/volatility3).

```shell
pip install volatility3
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ readme = "README.md"
authors = [
{ name = "Volatility Foundation", email = "volatility@volatilityfoundation.org" },
]
requires-python = ">=3.10.0"
requires-python = ">=3.8.0"
license = { text = "VSL" }
dynamic = ["version"]

Expand Down Expand Up @@ -48,8 +48,8 @@ test = [

docs = [
"volatility3[dev]",
"sphinx==8.0.2",
"sphinx-autodoc-typehints>=2.5.0,<3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this change is to work with the version of sphinx available? Again, I believe the lower bound was pulled up artificially when the pyproject.toml inhereited the values from the requirements.txt.

"sphinx>=7,<=7.1.2",
"sphinx-autodoc-typehints==2.0.1",
"sphinx-rtd-theme>=3.0.1,<4",
]

Expand Down
Loading