Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflicts in pyproject.toml #1548

Closed
wants to merge 2 commits into from
Closed

Fix dependency conflicts in pyproject.toml #1548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b9eda
Fix dependency conflicts in pyproject.toml
dgmcdona Jan 13, 2025
055c8db
Downgrade required versions of sphinx + related for 3.8
dgmcdona Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = { text = "VSL" }
dynamic = ["version"]

dependencies = [
"pefile>=2024.8.26",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong way to fix the issue. I don't think pefile is at fault, I believe it's the way that pyinstaller used it, and pyinstaller is only used by devs to construct an exe (and it's only a performance degradation), so I think we bump pyinstaller down (it used to start at 6.5, but during the toml update it got bump to the latest version at that time).

"pefile>=2023.2.7",
]

[project.optional-dependencies]
Expand Down Expand Up @@ -48,8 +48,8 @@ test = [

docs = [
"volatility3[dev]",
"sphinx>=8.0.0,<7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and it appears to builds with version 8 ok, so I'm not sure this needs to drop to 7, I think the higher version should bump to 9.

"sphinx-autodoc-typehints>=2.5.0,<3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this change is to work with the version of sphinx available? Again, I believe the lower bound was pulled up artificially when the pyproject.toml inhereited the values from the requirements.txt.

"sphinx>=7,<=7.1.2",
"sphinx-autodoc-typehints==2.0.1",
"sphinx-rtd-theme>=3.0.1,<4",
]

Expand Down
Loading