Rename site parameter to monitoring_site #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since “site” is a protected keyword, it may not be used as a parameter name.
|
Looks good to me. Needs major version due to incompatibility |
alexjfisher
requested changes
Mar 17, 2021
There was a problem hiding this comment.
This is a bug in Puppet 7 fixed in 7.5.0. See https://tickets.puppetlabs.com/browse/PUP-10929
Should we still rename it or just wait until 7.5 is out? |
|
I have added another commit to fix the failing tests, which are broken because of an unrelated issue. |
Since the content of encryption.cfg is sensitive, it directly. Instead, the content needs to be exctracted from the catalogue.
This was referenced Mar 23, 2021
Merged
|
Sorry, but I'm not interested in supporting Check_MK anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Since “site” is a protected keyword, it may not be used as a parameter name. I renamed it to “monitoring_site”.
This Pull Request (PR) fixes the following issues
Fixes #41