modulesync 5.1.0 #38
modulesync 5.1.0 #38
Conversation
|
I think this needs the |
bastelfreak
force-pushed
the
modulesync
branch
8 times, most recently
from
3c47aa5 to
cdbb460
Compare
| content = catalogue.resource('file', '/etc/check_mk/encryption.cfg').parameters[:content] | ||
| expect(content).to include("PASSPHRASE=SECRET\n") |
There was a problem hiding this comment.
I think you can check it with 'content' => sensitive('PASSPHRASE=SECRET\n') but I don't know if that supports partial matches.
| @@ -11,9 +11,41 @@ | |||
| } | |||
| end | |||
|
|
|||
| on_supported_os.each do |os, os_facts| | |||
| on_supported_os.each do |os, facts| | |||
There was a problem hiding this comment.
The use of os_facts is preferred nowadays. It avoids an overlap of variable names which can remove confusion.
spec/classes/check_mk_agent_spec.rb
Outdated
| on_supported_os.each do |os, os_facts| | ||
| let(:facts) { os_facts } | ||
| on_supported_os.each do |os, facts| | ||
| systemd_facts = case facts[:operatingsystem] |
There was a problem hiding this comment.
Given the repetition, perhaps this should live in a spec helper? The systemd_version fact can be a nice addition here:
https://github.com/voxpupuli/voxpupuli-test/blob/f6c85fe54412248339cbb8ebe197c0b95dbb5697/lib/voxpupuli/test/facts.rb#L53-L54
voxpupuli/modulesync_config#693 will then be needed to use it, but it can save a lot of duplication.
bastelfreak
force-pushed
the
modulesync
branch
2 times, most recently
from
cf6309b to
057dbce
Compare
modulesync 4.0.0