Collect facts iteratively #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 95.23% 95.20% -0.03%
==========================================
Files 2 2
Lines 168 167 -1
==========================================
- Hits 160 159 -1
Misses 8 8
☔ View full report in Codecov by Sentry. |
ekohl
force-pushed
the
reuse-found-facts
branch
3 times, most recently
from
0b0114e
to
d1f69b9
Compare
|
Test failure is because it no longer does the additional |
Rather than getting the facts for every filter spec and then discarding that, this stores the found facts in an array and uses that. This eliminates a call to FacterDB::get_facts with a very complex filter. A quick test in puppet-nginx reduces loading of tests by about 2 seconds (from ~9 to ~7).
bastelfreak
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than getting the facts for every filter spec and then discarding that, this stores the found facts in an array and uses that.
This eliminates a call to FacterDB::get_facts with a very complex filter.
A quick test in puppet-nginx reduces loading of tests by about 2 seconds (from ~9 to ~7).
This is a reworked version of #124 for a clean changelog. It requires #151 to be merged first.