Fix shouldTrace decision based on sampling decision from edge #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeymisson
commented
Sep 1, 2023
arturpimentel
approved these changes
Sep 12, 2023
arturpimentel
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is complimentary to the previous PR: #541
Jaeger client
tracer.extractwill always return a rootSpan context, the Sampling decision is inside this context, as we can see in it's code implementation, https://github.com/jaegertracing/jaeger-client-node/blob/29365a4475285423490813187ea48136b5135167/src/span_context.js#L186.Example of tagged trace through header:
jaeger-debug-id: trace-test-samplingWhat problem is this solving?
How should this be manually tested?
Screenshots or example usage
Types of changes