Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shouldTrace decision based on sampling decision from edge #542

Merged
merged 12 commits into from
Sep 19, 2023
Merged

Fix shouldTrace decision based on sampling decision from edge #542

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2783499
Fix shouldTrace decision based on sampling decision from edge
Jeymisson Sep 1, 2023
06b1152
Add comments to shouldTrace method
Jeymisson Sep 4, 2023
44d3131
Release v6.45.21-beta
Jeymisson Sep 4, 2023
43cbc77
Fix jsdoc lint
Jeymisson Sep 4, 2023
b3f0dd3
Release v6.45.21-beta.0
Jeymisson Sep 4, 2023
8394f2e
Make tracingMiddleware span creation optional
Jeymisson Sep 7, 2023
329dc52
Release v6.45.21-beta.1
Jeymisson Sep 7, 2023
25aa8d9
Remove dangling spans from HttpClient outgoing requests
Jeymisson Sep 19, 2023
1bf0a36
Release v6.45.21-beta.2
Jeymisson Sep 19, 2023
063cbb3
Remove uneccessary userland tracer null protection
Jeymisson Sep 19, 2023
27b3ac1
Update changelog
Jeymisson Sep 19, 2023
bb35489
Release v6.45.21
Jeymisson Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/service/tracing/tracingMiddlewares.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,6 @@ export const traceUserLandRemainingPipelineMiddleware = () => {
}
function shouldTrace(ctx: ServiceContext, rootSpan: SpanContext | undefined) {
// Should trace if path isnt blacklisted and tracing decision came from the edge
return !PATHS_BLACKLISTED_FOR_TRACING.includes(ctx.request.path) && rootSpan != null
return !PATHS_BLACKLISTED_FOR_TRACING.includes(ctx.request.path) && ((rootSpan as any).isSampled?.() ?? false)
arturpimentel marked this conversation as resolved.
Show resolved Hide resolved
}

Loading