T5400: Move libvyosconfig build out of the Docker image #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
11 tasks
jestabro
force-pushed
the
libvyosconfig-build
branch
3 times, most recently
from
a6d04a2 to
7e54ab8
Compare
12 tasks
jestabro
force-pushed
the
libvyosconfig-build
branch
from
7e54ab8 to
1bdceb8
Compare
libvyosconfig is both a build and a run dependency of vyos-1x. Satisfying the build dependency within the Docker image requires coordination of updates to vyos-build/libvyosconfig/vyos-1x on any changes to the library; simplify this process by moving the build to a step of the vyos-1x Makefile.
jestabro
force-pushed
the
libvyosconfig-build
branch
from
1bdceb8 to
731195c
Compare
c-po
approved these changes
Mar 4, 2025
|
CI integration 👍 passed! Details
|
sever-sever
approved these changes
Mar 4, 2025
kumvijaya
added
mirror-completed
and removed
mirror-initiated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
libvyosconfig is both a build and a run dependency of vyos-1x. Satisfying the build dependency within the Docker image requires coordination of updates to vyos-build/libvyosconfig/vyos-1x on any changes to the library; simplify this process by moving the build to a step of the vyos-1x Makefile.
Types of changes
Adjust build process.
Related Task(s)
Related PR(s)
vyos/vyos-build#923
How to test / Smoketest result
Checklist: